https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #1 from Athmane Madjoudj <athmanem@xxxxxxxxx> --- Looks good, here's few points to consider: 1. About license: it's preferable to ask upstream to include the license in the tarball (reference the request in the spec) 2. For readability reasons, it's recommended to put one requirement per line (Requires/BuildRequires and Recommends) 3. It seems that there's a test suite, but not included in the pypi tarball (not a blocker) https://github.com/INCF/pybids/tree/master/bids/grabbids/tests To fix point 1 and 3, you may want to switch to github tarball instead of pypi's Source0: https://github.com/INCF/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
