Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jetty5 - The Jetty Webserver and Servlet Container https://bugzilla.redhat.com/show_bug.cgi?id=202334 ------- Additional Comments From fitzsim@xxxxxxxxxx 2007-08-27 11:50 EST ------- rpmlint Comments ================ $ rpmlint jetty5-5.1.12-1jpp.1.fc8.i386.rpm | sort E: jetty5 non-standard-gid /var/cache/jetty5/temp jetty5 ... OK. rpmlint needs fedora-usermgmt support. E: jetty5 no-status-entry /etc/init.d/jetty5 Fix. I don't consider this release-critical but it should be fixed at some point. E: jetty5 zero-length /etc/jetty5/jetty.conf Fix. How about a comment header explaining this file? W: jetty5 dangling-symlink /usr/share/jetty5/ext/ant.jar /usr/share/java/ant.jar ... OK. All provided by requirements, except: W: jetty5 dangling-symlink /usr/share/jetty5/ext/jspapi.jar /usr/share/java/jspapi.jar Fix. Not provided by any required packages. Should: Requires: jsse be Requires: jsp ? W: jetty5 hidden-file-or-dir /usr/share/jetty5/.jettyrc Fix. Rename jettyrc. W: jetty5 invalid-license Apache Software License Fix. See new rpmlint -i output. W: jetty5 no-reload-entry /etc/init.d/jetty5 Fix. Again, not release critical. W: jetty5 spurious-executable-perm /etc/logrotate.d/jetty5 Fix. W: jetty5 symlink-should-be-relative /usr/share/jetty5/demo /var/lib/jetty5/demo ... Fix. Not release critical. $ rpmlint jetty5-javadoc-5.1.12-1jpp.1.fc8.i386.rpm | sort E: jetty5-javadoc zero-length /var/lib/jetty5/webapps/template/WEB-INF/lib/.keepme Fix. If this file's only purpose is to prevent CVS directory pruning then it should be removed in %build. W: jetty5-javadoc dangerous-command-in-%post ln Fix. See general comment above. W: jetty5-javadoc hidden-file-or-dir /var/lib/jetty5/webapps/template/WEB-INF/lib/.keepme Fix. W: jetty5-javadoc invalid-license Apache Software License Fix. W: jetty5-javadoc non-standard-group Development Fix. W: jetty5-javadoc wrong-file-end-of-line-encoding /usr/share/javadoc/jetty5-5.1.12/META-INF/MANIFEST.MF Fix. $ rpmlint jetty5-manual-5.1.12-1jpp.1.fc8.i386.rpm | sort E: jetty5-manual version-control-internal-file /usr/share/doc/jetty5-5.1.12/WEB-INF/.cvsignore Fix. W: jetty5-manual dangerous-command-in-%post ln Fix. W: jetty5-manual invalid-license Apache Software License Fix. W: jetty5-manual non-standard-group Development/Documentation Fix. $ rpmlint jetty5-debuginfo-5.1.12-1jpp.1.fc8.i386.rpm | sort W: jetty5-debuginfo invalid-license Apache Software License Fix. $ rpmlint jetty5-5.1.12-1jpp.1.fc8.src.rpm | sort W: jetty5 invalid-license Apache Software License Fix. Review Guidelines Comments ========================== MUST items: OK rpmlint OK naming OK spec filename FIX packaging guidelines see below FIX Fedora-approved license remove proprietary code to create modified source zip OK license field matches actual license FIX license file included in %doc include all license files as %doc, not just main LICENSE.TXT OK english OK legible FIX match upstream sources Source0 URL invalid OK package builds in x86 mock OK buildrequires OK no locale data OK no shared libraries OK not relocatable OK owns its directories FIX files listed twice warning: File listed twice: /usr/lib/gcj/jetty5 warning: File listed twice: /usr/lib/gcj/jetty5/jetty5-5.1.12.jar.db warning: File listed twice: /usr/lib/gcj/jetty5/jetty5-5.1.12.jar.so warning: File listed twice: /usr/lib/gcj/jetty5/jetty5-jmx-5.1.12.jar.db warning: File listed twice: /usr/lib/gcj/jetty5/jetty5-jmx-5.1.12.jar.so warning: File listed twice: /usr/lib/gcj/jetty5/jetty5-servlet-5.1.12.jar.db warning: File listed twice: /usr/lib/gcj/jetty5/jetty5-servlet-5.1.12.jar.so warning: File listed twice: /usr/lib/gcj/jetty5/start.jar.db warning: File listed twice: /usr/lib/gcj/jetty5/start.jar.so warning: File listed twice: /usr/lib/gcj/jetty5/stop.jar.db warning: File listed twice: /usr/lib/gcj/jetty5/stop.jar.so OK %clean OK consistent macros OK code vs content OK separate javadoc and manual subpackages OK proper operation not dependent on %doc files OK no header files OK no static libraries OK no pkgconfig files OK no .so files OK devel package requires base package OK no libtool archives OK no desktop entries OK doesn't own other packages' directories OK remove buildroot at start of %install OK UTF-8 filenames SHOULD items: OK project includes license file OK no translations available OK package builds in mock ?? didn't check all architectures OK jetty starts properly OK scriptlets sane FIX subpackages requiring base package remove '0:' epoch references in base package requires (extras and manual subpackages) javadoc subpackage doesn't require base which is fine OK placement of pkgconfig files OK package vs file requires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review