[Bug 1532364] Review Request: rpcsvc-proto - RPC protocol definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1532364



--- Comment #25 from Steve Dickson <steved@xxxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #24)
> Source URL is broken...
> 
> > Source0:        https://github.com/thkukuk/rpcsvc-proto/archive/%{name}-%{version}.tar.gz
> Should be Source0:       
> https://github.com/thkukuk/rpcsvc-proto/archive/v%{version/%{name}-
> %{version}.tar.gz
There is an unbalance 'v%{version' in this link... I think this is what you
mean
https://github.com/thkukuk/rpcsvc-proto/archive/v%{version}.tar.gz

But make note of the tar balls in previous release. The were all
in the %{name}-%{version}.tar.gz format so I'm thinking this might
be a typo by the upstream maintainer.

> 
> > Provides:       %{_bindir}/rpcgen
> Remove this, you already have file.
Gone.

> 
> > %dir %{_includedir}/rpcsvc
> This is still not removed
Gone.
> 
> > License:        BSD and LGPLv2+
> This is not needed for subpackage
Gone.


-- rpcsvc-proto.spec.v6    2018-01-10 09:06:41.902749055 -0500
+++ rpcsvc-proto.spec.v7    2018-01-13 09:37:53.694294293 -0500
@@ -22,7 +22,7 @@ Release:        1%{?dist}
 Summary:        RPC protocol definitions
 License:        BSD and LGPLv2+
 Url:            https://github.com/thkukuk/rpcsvc-proto
-Source0:       
https://github.com/thkukuk/rpcsvc-proto/archive/%{name}-%{version}.tar.gz
+Source0:       
https://github.com/thkukuk/rpcsvc-proto/archive/v%{version}.tar.gz

 Conflicts: glibc-headers < 2.26.9000-36
 Conflicts: glibc-common < 2.26.9000-36
@@ -42,9 +42,7 @@ glibc).

 %package -n rpcgen
 Summary:        RPC protocol compiler
-License:        BSD and LGPLv2+
 Provides:       rpcgen
-Provides:       %{_bindir}/rpcgen

 %description -n rpcgen
 rpcgen is a tool that generates C code to implement an RPC protocol.
@@ -64,7 +62,6 @@ The input to rpcgen is a language simila

 %files devel
 %license COPYING
-%dir %{_includedir}/rpcsvc
 %{_includedir}/rpcsvc/

 %files -n rpcgen

spec file under http://people.redhat.com/steved/rpcsvc-proto has been updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux