[Bug 1533490] Review Request: iucode-tool - iucode_tool is a program to manipulate microcode update collections for Intel i686 and X86-64 system processors , and prepare them for use by the Linux kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1533490



--- Comment #6 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
I disagree:

 - Use the correct tag to download the archive instead of "release_commit":

Source0:       
https://gitlab.com/iucode-tool/iucode-tool/repository/v2.2/archive.tar.gz#/%{name}-%{version}.tar.xz

 - Don't mix tabs and spaces, use one or the other:

iucode-tool.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line
10)

 - The "Summary:" must not exceed 80 characters:

iucode-tool.x86_64: E: summary-too-long C iucode_tool is a program to
manipulate microcode update collections for Intel i686 and X86-64 system
processors, and prepare them for use by the Linux kernel

 - The description should be split in multiples lines to stay below 80
characters per line:

iucode-tool.x86_64: E: description-line-too-long C iucode_tool is a program to
manipulate microcode update collections for Intel i686 and X86-64 system
processors, and prepare them for use by the Linux kernel.

 - Typo in the license field, it should be GPlv2+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux