https://bugzilla.redhat.com/show_bug.cgi?id=1531955 --- Comment #8 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Alec Leamas from comment #6) > Here comes the full list of issues I see after making a full review: > > - seqan2 obsoletes seqan without providing seqan. It's not needed. seqan2 and seqan must coexist for now. > - seqan2-devel does not depend on seqan2 = %{version}-%{release}. Why? > - A binary zip file is present in the examples package. > - Several bundled files/directories in util/py_lib/seqan/dox/tpl/lib and > include/seqan/stream. Please either remove these in %prep and/or bundle > properly using Provides: bundled(...) I have already said why it's not needed. And why 'include/seqan/stream'? > - The License field comment does not match the actual file licenses in the > sources. My proposal: Remove in %prep, add a text document describing > the licensing situation. https://bugzilla.redhat.com/show_bug.cgi?id=1531955#c4 > - There are tests available. Why are these not run? Tests are performed in %check. > - The pkg-config file is not shipped with the -devel package for no obvious > reason. > - Likewise for seqan-config.cmake. > Why? Is it indispensable? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
