https://bugzilla.redhat.com/show_bug.cgi?id=1532696 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - COPYING should be included with %license, not %doc: %doc AUTHORS {Changelog,README}.html %license COPYING - You should own the following directories: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/gcin, /usr/share/gcin - BuildRequires: qt3-devel seems obsolete The qt package is not built anymore. - These files are wrongly marked as executables, please remove the executables bits in %prep: gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-conf.h gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-module.h gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-settings.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-setup-gtab.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-setup-pho.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gtab-init.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/im-client/gcin-im-client.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/im-client/gcin-im-client.h gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/im-srv.h gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/util.cpp./gtab-init.cpp → find . -type f -executable -regex ".*\.\(cpp\|h\)" -exec chmod 0644 "{}" \; Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like) NTP (legal disclaimer)", "LGPL (v2 or later)", "GPL (v2)", "NTP (legal disclaimer)", "Unknown or generated". 653 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gcin/review-gcin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gcin [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/gcin, /usr/share/gcin [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in gcin-data [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 307200 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gcin- data , gcin-libs , gcin-table [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gcin-2.8.5-1.fc28.x86_64.rpm gcin-anthy-2.8.5-1.fc28.x86_64.rpm gcin-data-2.8.5-1.fc28.noarch.rpm gcin-gtk2-2.8.5-1.fc28.x86_64.rpm gcin-gtk3-2.8.5-1.fc28.x86_64.rpm gcin-im-client-2.8.5-1.fc28.x86_64.rpm gcin-libs-2.8.5-1.fc28.x86_64.rpm gcin-qt4-2.8.5-1.fc28.x86_64.rpm gcin-qt5-2.8.5-1.fc28.x86_64.rpm gcin-table-2.8.5-1.fc28.noarch.rpm gcin-debuginfo-2.8.5-1.fc28.x86_64.rpm gcin-debugsource-2.8.5-1.fc28.x86_64.rpm gcin-2.8.5-1.fc28.src.rpm gcin.x86_64: W: invalid-license Array gcin.x86_64: W: only-non-binary-in-usr-lib gcin.x86_64: W: no-manual-page-for-binary gtab-db-gen gcin.x86_64: W: no-manual-page-for-binary phod2a gcin.x86_64: W: no-manual-page-for-binary trad2sim gcin.x86_64: W: no-manual-page-for-binary ts-contribute-en gcin.x86_64: W: no-manual-page-for-binary ts-edit-en gcin.x86_64: W: no-manual-page-for-binary tsd2a32 gcin.x86_64: W: no-manual-page-for-binary tsin2gtab-phrase gcin.x86_64: W: no-manual-page-for-binary txt2gtab-phrase gcin.x86_64: W: percent-in-%postun gcin-anthy.x86_64: W: invalid-license Array gcin-anthy.x86_64: W: no-documentation gcin-data.noarch: W: invalid-license Array gcin-data.noarch: W: no-documentation gcin-gtk2.x86_64: W: invalid-license Array gcin-gtk2.x86_64: W: no-documentation gcin-gtk3.x86_64: W: invalid-license Array gcin-gtk3.x86_64: W: no-documentation gcin-im-client.x86_64: W: invalid-license Array gcin-im-client.x86_64: W: no-documentation gcin-im-client.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gcin/libgcin-im-client.so gcin-libs.x86_64: W: invalid-license Array gcin-libs.x86_64: W: no-documentation gcin-qt4.x86_64: W: invalid-license Array gcin-qt4.x86_64: W: obsolete-not-provided gcin-qt3 gcin-qt4.x86_64: W: no-documentation gcin-qt5.x86_64: W: invalid-license Array gcin-qt5.x86_64: W: obsolete-not-provided gcin-qt4 gcin-qt5.x86_64: W: no-documentation gcin-table.noarch: W: invalid-license Array gcin-table.noarch: W: no-documentation gcin-debuginfo.x86_64: W: invalid-license Array gcin-debugsource.x86_64: W: invalid-license Array gcin-debugsource.x86_64: W: no-documentation gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-conf.h gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-module.h gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-settings.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-setup-gtab.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin-setup-pho.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gcin.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/gtab-init.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/im-client/gcin-im-client.cpp gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/im-client/gcin-im-client.h gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/im-srv.h gcin-debugsource.x86_64: W: spurious-executable-perm /usr/src/debug/gcin-2.8.5-1.fc28.x86_64/util.cpp gcin.src: W: invalid-license Array gcin.src:126: W: macro-in-comment %{_libdir} 13 packages and 0 specfiles checked; 0 errors, 48 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
