https://bugzilla.redhat.com/show_bug.cgi?id=1532042 Iwicki Artur <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Iwicki Artur <fedora@xxxxxxxxxx> --- >Release: 0 The "Release:" tag should start at 1. https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning >Group: System/X11/Utilities The "Group:" tag is not used in Fedora. >BuildRoot: %{_tmppath}/%{name}-%{version}-build The "BuildRoot:" tag should not be used in Fedora. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >Source0: https://github.com/chjj/compton/archive/v0.1_beta2.tar.gz You can use the %{version} macro inside the URL so you don't have to edit it when a new version comes out. >%__make >make DESTDIR=%{buildroot} install Why the mix of macro and "raw" make calls? >%doc README.md LICENSE The LICENSE file should be marked as %license, not %doc. >%{_mandir}/man1/compton.1.gz >%{_mandir}/man1/compton-trans.1.gz You should not assume gzip compression will be used for manpages. Instead, use a wildcard that can match both compressed and non-compressed files. https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
