Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Emesene - Emesene is an MSN Messenger client written in python and GTK Alias: Emesene https://bugzilla.redhat.com/show_bug.cgi?id=238379 ------- Additional Comments From wilmer@xxxxxxxxxxxxxxxxx 2007-08-26 19:38 EST ------- Hi Jason. > I can't compare the sources with upstream, because this is a checkout from a > subversion tree. It's OK to package snapshots like this, but you need to > provide instructions on creating the tarball you are packaging. See > http://fedoraproject.org/wiki/Packaging/SourceURL Thank you, i don't know this page, is good information, fixed of course. > You're using the versioning scheme for post-release snapshots, but according to > the upstream URL it seems to me that version 1.0 has not been released. Thus > you'd have to use a version-release of something like 1.0-0.2.20070711svn, so > that when 1.0 is finally released you can go to just 1.0-1. See > http://fedoraproject.org/wiki/Packaging/NamingGuidelines (look for the > "Pre-Release packages" section). Fixed. ;) > I would remove "It's" from the summary, as I can't think of any summaries that > begin with pronouns. This isn't a big deal, however. Fixed. > Your call to desktop-file-install is a little weird; why is it indented like that? desktop-file-install only permit install emesene.desktop files on /usr/share/applications/ directory for the menu in desktops environments such as GNOME or KDE, and update-desktop-database is necessary for update the main menu with the emesene icon and MIME information in the desktops environments. > /usr/share/emesene is unowned; change %{_datadir}/%{name}/* in %files to > %{_datadir}/%{name} to fix it. Fixed. > ? latest version is being packaged. Since svn just the last version tested and stable, soon the _first_ release candidate of emesene. Please refresh with the last update: Spec URL: http://www.linuxtachira.org/review/emesene.spec SRPM URL: http://www.linuxtachira.org/review/emesene-1.0-0.3.20070711svn.src.rpm Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review