Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series https://bugzilla.redhat.com/show_bug.cgi?id=250970 ------- Additional Comments From nicolas.mailhot@xxxxxxxxxxx 2007-08-26 14:55 EST ------- Ok, my take (not a full review since that's already started, just a few additions/confirmations) 1. there is a lot of legacy garbage in the spec (symlinks, deps, epochs, etc). ivtv took enough time to get cleanly upstream, IMHO the supporting packages need the same cleanup too. Cleaning up later will be painful and users expect some changes at Fedora inclusion time 2. URL should be http://www.ivtvdriver.org/ 3. I'd simplify %install in %install rm -rf %{buildroot} install -d -m 0755 %{buildroot}/lib/firmware install -p -m 0644 *.fw *.mpg %{buildroot}/lib/firmware/ 4. I'd simplify %files in %files %defattr(0755,root,root,0644) %doc *.txt /lib/firmware/*.fw /lib/firmware/*.mpg 5. I'd add a %build, even if it's empty, because %build-less specs are not tested against @rpm.org 6. I'd change the summary to only include the actual chip reference and out the full "… for hardware based on Conexant's CX23415/CX23416 codec chip such as the Hauppauge PVR 150/250/350/500 models and other supported hardware." in %description, as the current string is misleading and overly restrictive 7. the deps if any should go in the tools not in the firmware package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review