https://bugzilla.redhat.com/show_bug.cgi?id=1530771 Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: python-lupa |python3-lupa - Lupa |- Lupa integrates the |integrates the runtimes of |runtimes of Lua or LuaJIT2 |Lua or LuaJIT2 into CPython |into CPython --- Comment #4 from Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - Remove the superfluous %check > %check removed. > - Source0 could be simplified like this: > > Source0: > https://github.com/scoder/%{srcname}/archive/%{srcname}-%{version}/ > %{srcname}-%{srcname}-%{version}.tar.gz > Source0 simplified. > - The Github page states it is also compatible with Python 2.6 and later > ("tested with Python 2.6/3.2 and later"). You should probably generate both > python2 and python3 subpackages. Generated both python2 and python3 subpackages. Spec Url: https://pagure.io/rpm-packaging/raw/master/f/python-lupa/python-lupa.spec SRPM Url: https://pagure.io/rpm-packaging/raw/master/f/python-lupa/python-lupa-1.6-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
