[Bug 1520582] Review Request: perl-Mojolicious-Plugin-I18N - Internationalization Plugin for Mojolicious

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1520582



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Url and Source0 are usable. Ok.
Source0 archive (SHA-256:
32fb5ef8037d954b7ecebef5c1b2b24b420abd829702312f4ad42794f52b514d) is original.
Ok.
Summary verified from lib/Mojolicious/Plugin/I18N.pm. Ok.

TODO: The description text is missing a full stop before "It" word.

FIX: The License tag is wrong. lib/Mojolicious/Plugin/I18N.pm and README.pod
states "Artistic 2.0". The specification at Build.PL:7 is probably a mistake.

FIX: Build-require 'perl(constant)' (lib/Mojolicious/Plugin/I18N.pm:153).
FIX: Build-require 'perl(I18N::LangTags::Detect)'
(lib/Mojolicious/Plugin/I18N.pm:6).
FIX: Build-require 'perl(Mojo::Base)' (lib/Mojolicious/Plugin/I18N.pm:2).
FIX: Build-require 'perl(Mojo::URL)' (lib/Mojolicious/Plugin/I18N.pm:4).
FIX: Build-require 'perl(Mojolicious::Plugin)'
(lib/Mojolicious/Plugin/I18N.pm:2)'.

FIX: Build-require 'perl(base)' (t/i18n.t:16).
FIX: Build-require 'perl(lib)' (t/i18n.t:2).
FIX: Build-require 'perl(Locale::Maketext)' (t/i18n.t:16).
FIX: Build-require 'perl(Mojolicious::Lite)' (t/i18n.t:29).

TODO: You should run-require 'perl(Mojolicious) >= 5' for the same reason as
you build-require it.

Please correct all 'FIX' items, consider fixing 'TODO' items, and provide a new
spec file.
Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux