https://bugzilla.redhat.com/show_bug.cgi?id=1530771 Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@xxxxxxxxx | |) --- Comment #2 from Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - Remove the superfluous %check > > - Source0 could be simplified like this: > > Source0: > https://github.com/scoder/%{srcname}/archive/%{srcname}-%{version}/ > %{srcname}-%{srcname}-%{version}.tar.gz > > - The Github page states it is also compatible with Python 2.6 and later > ("tested with Python 2.6/3.2 and later"). You should probably generate both > python2 and python3 subpackages. Thanks for the review. I'll make the necessary changes and update here again. On the other hand, I am a bit skeptical about the license. Are you sure what I've mentioned is correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
