[Bug 1530431] Review Request: nodepool - nodes management for a distributed test infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1530431



--- Comment #2 from Tristan Cacqueray <tdecacqu@xxxxxxxxxx> ---
Thanks for the review Robert.

Spec URL: https://fedorapeople.org/~tdecacqu/pkgs/nodepool.spec
SRPM URL:
https://fedorapeople.org/~tdecacqu/pkgs/nodepool-0.4.0-1.20171214gita20d81c.fc27.src.rpm

New version changes:

- Add %{?systemd_requires}
- Uses %license instead of %doc
- Uses %global gitdate 20171214
- Fixes release and changelog using 1.%{gitdate}git%{shortcommit}%{?dist}
- Fixes LICENSE encoding
- Add logrotate configuration
- Add manpage with help2man
- Fixes %file directives for correct ownership
- Remove sphinx buildinfo


Regarding the remaining rpmlint errors:

non-readable and zero-length /etc/nodepool/secure.conf is expected and may be
removed in the final release. This is a legacy file unused anymore, but the
service still tries to load it.

non-standard-dir-perm 750 are expected because those directory should only be
available to the nodepool user. Not sure why this is an error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux