Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: python-urlgrabber https://bugzilla.redhat.com/show_bug.cgi?id=226347 ------- Additional Comments From jbowes@xxxxxxxxxx 2007-08-25 18:07 EST ------- Notes: X package meets packaging guidelines: %install should being by removing the buildroot * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. X license field matches the actual license. * license is open source-compatible. * License text included in package. * source files match upstream * latest version is being packaged. * BuildRequires are proper. * package builds in mock. X rpmlint has 3 warnings: W: python-urlgrabber invalid-license LGPL W: python-urlgrabber redundant-prefix-tag W: python-urlgrabber setup-not-quiet * final provides and requires are sane: urlgrabber = 3.0.0-1.fc7 python-urlgrabber = 3.0.0-1.fc7 ====== /usr/bin/python python(abi) = 2.5 * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present * scriptlets OK * code, not content. * upstream includes no docs. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. The license must be updated and %install must be fixed as well. The other two rpmlint warnings should be fixed as well. Source0 should also be a url. I'll approve the package when these are fixed. Three nice to haves: * use one of the three standard buildroot definitions * use the 4 arg form of defattr * use the single '%{python_sitelib}/urlgrabber' in files rather than the two %dir and /* lines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review