Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alsa-firmware - Firmware for several ALSA-supported sound card https://bugzilla.redhat.com/show_bug.cgi?id=217259 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-08-25 14:35 EST ------- Actually rpmlint isn't quite completely clean: W: alsa-firmware invalid-license GPL E: alsa-firmware arch-independent-package-contains-binary-or-object /lib/firmware/mixart/miXart8.elf The latter is OK, but the former is not. I see a GPL copying file and some LGPL headers in some of the code (echoaudio/DSP/Echo3gDSP.c, for example), plus weird things like "aica/license.txt". Honestly I don't think it's the package reviewer's job to do complete license review and I'm certainly not a lawyer so I can't really do so in any case. The other issues I had are fixed now, so I'll just leave it to you to make a determination as to what the new-style License: tag should be (ping spot or block FE-Legal if you need to) and then go ahead and check in. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review