[Bug 1530352] Review Request: calligraplan - A Project Planner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1530352

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - gtk-update-icon-cache is invoked in %postun and %posttrans if package
   contains icons.
  Note: icons in calligraplan
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache


 - Are the *so dl-opened or did you forget to split them in a devel subpackage
and call ldconfig?

- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in calligraplan-libs
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries



 - update-desktop-database and update-mime-database should not be used in F25
and later:
https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#desktop-database

 - Package should Requires: hicolor-icon-theme

 - The Requires should be %{name}%{_isa} = %{version}-%{release}

%package  libs
Summary:  Runtime libraries for %{name}
Obsoletes: calligra-plan-libs < 3.0.90
Requires: %{name} = %{version}-%{release}

 - Remove this test locale from install:

calligraplan.x86_64: E: incorrect-locale-subdir
/usr/share/locale/x-test/LC_MESSAGES/calligraplan.mo
calligraplan.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/x-test/LC_MESSAGES/calligraplan.mo
calligraplan.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/x-test/LC_MESSAGES/calligraplan_scheduler_rcps.mo
calligraplan.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/x-test/LC_MESSAGES/calligraplan_scheduler_tj.mo
calligraplan.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/x-test/LC_MESSAGES/calligraplanlibs.mo
calligraplan.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/x-test/LC_MESSAGES/calligraplanwork.mo
calligraplan.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/x-test/LC_MESSAGES/krossmoduleplan.mo

 - Missing a Provides?

calligraplan-libs.x86_64: W: obsolete-not-provided calligra-plan-libs

 - Some dirs are left with no owner:

[!]  Note: Directories without known owners: /usr/share/locale/x-test,
     /usr/share/config.kcfg, /usr/share/icons/hicolor/1024x1024,
     /usr/share/locale/x-test/LC_MESSAGES, /usr/share/icons/hicolor,
     /usr/share/kxmlgui5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux