[Bug 1529402] Review Request: python3-docker-pycreds - Python bindings for the docker credentials store API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1529402



--- Comment #3 from Carl George <carl@george.computer> ---
> Enclose your subpackage like this, otherwise it creates a conflict if python version is 3 and mock/fedora-review can't process the SPEC:

I don't think that is the best approach.  It's an EPEL-only spec file that
works fine on RHEL/CentOS.  The issue you are describing is specific to Fedora.
 I don't think the spec file should carry extra lines just to make rpmlint
happy on an OS that it should never be built for.  To parse a spec file like
this under Fedora, I think it makes more sense to just use temporary macros
definitions.

$ rpmlint python3-docker-pycreds.spec
python3-docker-pycreds.spec: E: specfile-error error: Package already exists:
%package -n python3-docker-pycreds
python3-docker-pycreds.spec: E: specfile-error error: query of specfile
python3-docker-pycreds.spec failed, can't parse
0 packages and 1 specfiles checked; 2 errors, 0 warnings.
$ echo '%python3_pkgversion 34' >> ~/.rpmmacros
$ rpmlint python3-docker-pycreds.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ sed -i '/%python3_pkgversion/d' ~/.rpmmacros

For comparison's sake, none of the other EPEL-only python3 spec files for
python34 stack contain such a conditional.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux