https://bugzilla.redhat.com/show_bug.cgi?id=1529352 --- Comment #5 from Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #4) > Iwicki is correct about those two points. Yes, of course… But his suggestions are more a matter of taste, then 'hard-coded' rules. > Not sure why you added explicit install to %_pkgdocdir; you could just list > the > relative paths in %doc directly. Is it to be able to delete .*ignore* and > meson.build from the installed version? I did that, so all built (sub-)packages share the same dir for documentation; if you simply add the relative paths using %%doc, every %package will get a seperate dir laying inside of %%{_defaultdocdir}. > Need to add BuildRequires on gcc and/or g++: > https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B Fixed. > A couple files are not MIT; they are not installed, but I think some > transformation of them is. Not exactly sure what the legal meaning of that > is, > or if you need to mention that in the license field. I added some clarification comment to the spec file. > It would be nice if the description said a bit more than the summary. Well, at some day in the future, when upstream writes a better one… > Package Review > ============== > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "NTP (legal > disclaimer)", "Unknown or generated". 197 files have unknown license. > Detailed output of licensecheck in > /home/elliott/rpmbuild/review/1529352-wlroots/licensecheck.txt See added clarification in the spec file. *** === Updated package === Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=23955196 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/wlroots.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/wlroots-0.0.1-0.4.20171229git80ed4d4.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
