[Bug 1529824] Review Request: awx - AWX, Ansible Management GUI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1529824



--- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> ---
This covers the major issues:

* Amazon Linux doesn't use Upstart anymore. They just released Amazon Linux 2,
which uses systemd and they're no longer supporting Amazon Linux AMI v1 (which
used upstart). Aside from that, packages for Fedora and EPEL cannot have Amazon
Linux specific conditionals.

c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_Legibility

* Your Source0 is invalid. It needs to point to valid URL or have a comment of
some kind describing where it came from.

c.f.: https://fedoraproject.org/wiki/Packaging:SourceURL

* License is wrong. It's "ASL 2.0", not GPLv3:
https://github.com/ansible/awx/blob/devel/LICENSE.md

* Vendor, Prefix, and BuildRoot tags MUST NOT be used.
* Group is not mandatory, but when used, should match one of the following
groups: https://fedoraproject.org/wiki/RPMGroups

c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Relocatable_packages

* Packaging virtualenvs is not permitted in Fedora. Moreover, there is no
internet access in the build environment, so packaging virtualenvs is
functionally impossible.

c.f.:
https://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access

* Web app files should be installed into `/usr/share/%{name}` rather than in a
weird virtualenv location.

c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Web_Applications

Packages like AWX can absolutely work in Fedora and EPEL, you just need to
leverage the system packages for its dependent components.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux