https://bugzilla.redhat.com/show_bug.cgi?id=1515701 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review+ --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Looks good to me. Some suggestions: 1) Change the "%setup -q" to "%autosetup". See how it will benefit -> https://fedoraproject.org/wiki/Packaging:Guidelines#.25autosetup 2) Use %license macro for marking license file %license LICENSE See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text 3) Also, good to add docs subpackage as recommended above except you need to use pushd docs PYTHONPATH=%{buildroot}%{python3_sitelib} sphinx-build-3 -b html -d _build/doctrees . _build/html popd I have modified your spec and my modifications are ======================================================================= --- diceware.spec 2017-12-27 14:14:49.000000000 +0530 +++ diceware.spec.new 2017-12-27 15:50:19.655108962 +0530 @@ -18,9 +18,20 @@ A simple command line tool which can create simple passphrases which human can remember. +%package doc +Summary: Documentation for Diceware + +BuildArch: noarch +BuildRequires: python3-sphinx +BuildRequires: python3-sphinx_rtd_theme + +%description doc +A simple command line tool which can create simple passphrases +which human can remember. + %prep -%setup -q +%autosetup %build @@ -32,12 +43,23 @@ mkdir -p %{buildroot}%{_mandir}/man1 rst2man docs/manpage.rst %{buildroot}%{_mandir}/man1/diceware.1 +pushd docs +PYTHONPATH=%{buildroot}%{python3_sitelib} sphinx-build-3 -b html -d _build/doctrees . _build/html +popd + +# Remove unneeded build artifacts. +rm -rf docs/_build/.buildinfo +rm -rf docs/_build/.doctrees + %check PYTHONPATH=%{buildroot}%{python3_sitelib} py.test-%{python3_version} +%files doc +%doc docs/_build/html %files -%doc LICENSE README.rst +%doc README.rst COPYRIGHT +%license LICENSE %{_bindir}/%{name} %{python3_sitelib}/%{name}* %{_mandir}/man1/diceware.1* ============================================================================ APPROVED (provided you will use above changes) :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
