https://bugzilla.redhat.com/show_bug.cgi?id=1527820 Bug ID: 1527820 Summary: Request: go-hvkvp - Utility to read keyvalue pairs from the Hyper-V Data Exechange service Product: Container Development Kit (CDK) Component: releng Severity: medium Assignee: jgregusk@xxxxxxxxxx Reporter: prkumar@xxxxxxxxxx QA Contact: optak@xxxxxxxxxx CC: extras-qa@xxxxxxxxxxxxxxxxx, kanderso@xxxxxxxxxx, lmohanty@xxxxxxxxxx, me@xxxxxxxxx, nobody@xxxxxxxxxxxxxxxxx, package-review@xxxxxxxxxxxxxxxxxxxxxxx, sgirijan@xxxxxxxxxx, timoran@xxxxxxxxxx, zebob.m@xxxxxxxxx Depends On: 1524245 Docs Contact: rkratky@xxxxxxxxxx +++ This bug was initially created as a clone of Bug #1524245 +++ Spec URL: https://raw.githubusercontent.com/gbraad/go-hvkvp/master/hvkvp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/gbraad/go-hvkvp/epel-7-x86_64/00686411-go-hvkvp/go-hvkvp-0.4-2.el7.centos.src.rpm Description: Utility to read keyvalue pairs from the Hyper-V Data Exechange service This utility is used by Minishift to provide a static IP on startup. This has been implemented as part of the task: https://github.com/minishift/minishift/issues/1316 The current package is unsigned and has been part of an experimental feature, but we now want to move ahead with a general availability. Fedora Account System Username: gbraad --- Additional comment from Robert-André Mauchin on 2017-12-11 19:07:08 EST --- Hello, - Not useful: %if ! 0%{?with_bundled} export GOPATH=$(pwd):%{gopath} %else echo "Unable to build from bundled deps. No Godeps nor vendor directory" exit 1 %endif - Remove unused stuff: # Build with debug info rpm %global with_debug 1 # Run tests in check section %global with_check 1 - What are you trying to do here? You make a directory just to remove it on the next line: %build mkdir -p src/%{import_path} rmdir src/%{import_path} ln -s ../../../ src/%{import_path It should look like this: mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project} ln -s $(pwd) ./_build/src/%{provider_prefix} export GOPATH=$(pwd)/_build:%{gopath} %gobuild -o bin/%{executable_name} %{import_path}/cmd/%{executable_name} - Not needed even for EL6/7: # handle license on el{6,7}: global must be defined after the License field above %{!?_licensedir: %global license %doc} - Changelog info is not coherent with the header. It should just be: * Mon Dec 11 2017 Gerard Braad <me@xxxxxxxxx> 0.4-0.2 - Use a more meaningful name for your archive, with: Source0: https://%{provider_prefix}/archive/%{version}/%{name}-%{version}.tar.gz Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1524245 [Bug 1524245] Review Request: go-hvkvp - Utility to read keyvalue pairs from the Hyper-V Data Exechange service -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
