[Bug 1527682] Review Request: python-requests-gssapi - A Python requests module for GSSAPI/SPNEGO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1527682

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ngompa13@xxxxxxxxx



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
A few spec comments:

> BuildRequires: git

Use "BuildRequires: git-core" to shorten the dep chain for buildroot (cuts out
a lot of weird Perl things you're not even using ;) )

> %{?python_provide:%python_provide python2-%{sname}}

This needs to be part of the subpackage preamble, not the description. Also,
you need a version for the python 3 flavor, too.

This package also needs adjustments to build in EPEL 7 Python 3, as that's
going to be necessary for Koji.

See for an example:
https://src.fedoraproject.org/rpms/python-pika/blob/master/f/python-pika.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux