https://bugzilla.redhat.com/show_bug.cgi?id=1526170 --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > $ rpm -qp --requires perl-Cpanel-JSON-XS-3.0239-1.fc28.x86_64.rpm | sort | > uniq -c > 1 libc.so.6()(64bit) > 1 libc.so.6(GLIBC_2.14)(64bit) > 1 libc.so.6(GLIBC_2.2.5)(64bit) > 1 libc.so.6(GLIBC_2.3.4)(64bit) > 1 libc.so.6(GLIBC_2.4)(64bit) > 1 libperl.so.5.26()(64bit) > 1 perl(Cpanel::JSON::XS) > 1 perl(Exporter) > 1 perl(:MODULE_COMPAT_5.26.1) > 1 perl(overload) > 1 perl(XSLoader) > 1 rpmlib(CompressedFileNames) <= 3.0.4-1 > 1 rpmlib(FileDigests) <= 4.6.0-1 > 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > 1 rpmlib(PayloadIsXz) <= 5.2-1 > 1 rtld(GNU_HASH) > FIX: Please add following run-requires: > - perl(Carp) - XS.pm:204 Ok. > $ rpm -qp --requires perl-Cpanel-JSON-XS-bin-3.0239-1.fc28.x86_64.rpm | sort > | uniq -c > 1 perl(Cpanel::JSON::XS) > 1 perl(Encode) > 1 perl(Getopt::Long) > 1 perl(Storable) > 1 perl(strict) > 1 rpmlib(CompressedFileNames) <= 3.0.4-1 > 1 rpmlib(FileDigests) <= 4.6.0-1 > 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > 1 rpmlib(PayloadIsXz) <= 5.2-1 > 1 /usr/bin/perl > FIX: To be able converted all format mention in man pages, you should > listed these dependencies in run-requires or at least mention them > as weak dependencies: > - perl(CBOR::XS) > - perl(Convert::Bencode) > - perl(Compress::LZF) > - perl(CPAN::Meta::YAML) > - perl(Data::Dump) > - perl(Data::Dumper) > - perl(YAML) > - perl(YAML::Syck) > - perl(YAML::XS) FIX: The dependencies should be added to list of Requires or Recommends for package perl-Cpanel-JSON-XS-bin, not to build-requires. > BuildRequires > FIX: Please add following build-requires: > - perl(Carp) - XS.pm:204 > - perl(Exporter) - XS.pm:224 > - perl(overload) - XS.pm:2210 > - perl(Data::Dumper) - t/22_comment_at_eof.t:10 > - perl(Encode) - t/20_faihu.t > - perl(strict) - most of the tests > FIX: Please add perl-devel and gcc, because it is XS package. Ok. > TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. Ok. Please correct 'FIX' issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
