https://bugzilla.redhat.com/show_bug.cgi?id=1526170 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Cpanel-JSON-XS-3.0239-1.fc28.x86_64.rpm | sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.26()(64bit) 1 perl(Cpanel::JSON::XS) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(overload) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) FIX: Please add following run-requires: - perl(Carp) - XS.pm:204 $ rpm -qp --requires perl-Cpanel-JSON-XS-bin-3.0239-1.fc28.x86_64.rpm | sort | uniq -c 1 perl(Cpanel::JSON::XS) 1 perl(Encode) 1 perl(Getopt::Long) 1 perl(Storable) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 /usr/bin/perl FIX: To be able converted all format mention in man pages, you should listed these dependencies in run-requires or at least mention them as weak dependencies: - perl(CBOR::XS) - perl(Convert::Bencode) - perl(Compress::LZF) - perl(CPAN::Meta::YAML) - perl(Data::Dump) - perl(Data::Dumper) - perl(YAML) - perl(YAML::Syck) - perl(YAML::XS) $ rpm -qp --provides perl-Cpanel-JSON-XS-3.0239-1.fc28.x86_64.rpm | sort | uniq -c 1 perl(Cpanel::JSON::XS) = 3.0239 1 perl-Cpanel-JSON-XS = 3.0239-1.fc28 1 perl-Cpanel-JSON-XS(x86-64) = 3.0239-1.fc28 Binary provides are Ok. $ rpm -qp --provides perl-Cpanel-JSON-XS-bin-3.0239-1.fc28.x86_64.rpm | sort | uniq -c 1 perl-Cpanel-JSON-XS-bin = 3.0239-1.fc28 1 perl-Cpanel-JSON-XS-bin(x86-64) = 3.0239-1.fc28 Binary provides are Ok. $ rpmlint ./perl-Cpanel-JSON-XS* perl-Cpanel-JSON-XS.src: W: spelling-error %description -l en_US versa -> avers, verse, verso perl-Cpanel-JSON-XS.x86_64: W: spelling-error %description -l en_US versa -> avers, verse, verso 3 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok BuildRequires FIX: Please add following build-requires: - perl(Carp) - XS.pm:204 - perl(Exporter) - XS.pm:224 - perl(overload) - XS.pm:2210 - perl(Data::Dumper) - t/22_comment_at_eof.t:10 - perl(Encode) - t/20_faihu.t - perl(strict) - most of the tests FIX: Please add perl-devel and gcc, because it is XS package. TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. Please correct all 'FIX' issues and consider fixing 'TODO' item and provide new spec file. The package not approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
