https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Michael Cullen <michael@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@xxxxxxxxxxxxxxxxx --- Comment #2 from Michael Cullen <michael@xxxxxxxxxxxxxxxxx> --- Ok... a few things I note: * The BuildRequires are at the top - I'd expect the name block at the top. * This bundles cctz without any comments as to why * Have you tried unbundling boost? Although it looks for 1.60 the bundled version is 1.65 so I'd guess the version isn't actually that critical - a small patch to remove the version number would most likely be all that's required * The CMake file seems to support ARM builds - any reason to make this exclusivearch other than the docs claiming it is? * Groups aren't needed or particularly wanted [1] [1] https://fedoraproject.org/wiki/RPMGroups -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
