https://bugzilla.redhat.com/show_bug.cgi?id=1526429 --- Comment #4 from Jonny Heggheim <hegjon@xxxxxxxxx> --- Thanks for doing the review. (In reply to Robert-André Mauchin from comment #3) > - Not needed for Fedora > 24: > > %post > /usr/bin/update-desktop-database &> /dev/null || : > > %postun > /usr/bin/update-desktop-database &> /dev/null || : Thanks, I did not know, will update my other packages also. > - appdata shall now be installed in %{_datadir}/metainfo/: > > install -Dpm 644 %{SOURCE3} > %{buildroot}%{_datadir}/metainfo/%{name}.appdata.xml > > Check: > > %check > appstream-util validate-relax --nonet > %{buildroot}/%{_datadir}/metainfo/*.appdata.xml > > And in %files: > > %{_datadir}/metainfo/%{name}.appdata.xml Thanks, I was not aware of this change. > - License "and BSD" → What parts of the code is BSD? Add a comment > explaining the license breakdown. Good catch, there was a socks.py with BSD license in an earlier version that have been removed. Will change the license to MIT only. > - Be a bit more specific in %files: > > %{python3_sitelib}/electroncash* > %{python3_sitelib}/Electron_Cash-3.0-py?.?.egg-info Will update -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
