[Bug 1526705] Review Request: python-f5-icontrol-rest - F5 BIG-IP iControl REST API client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1526705

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Grab the license from upstream GIT repo:

Source1:       
https://raw.githubusercontent.com/F5Networks/f5-icontrol-rest-python/1.0/LICENSE

   Then:

%prep
%autosetup -n %{srcname}-%{version}
cp %{S:1} .

   And:

%files -n python2-%{srcname}
%doc README.rst
%license LICENSE
%{python2_sitelib}/*

%if 0%{?with_python3}
%files -n python3-%{srcname}
%doc README.rst
%license LICENSE
%{python3_sitelib}/*
%endif

 - You've made a typo here:

BuildRequires:  python3-stuptools

→ setuptools

 - The tests and docs are not included in the Pipy archive. I strongly
encourage you to consider grabbing the archive from Github instead, build the
doc with Sphinx and run the tests with py.test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux