[Bug 1523909] Review Request: kernel-tools - Assortment of tools for the Linux kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1523909



--- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
>> Generic:
>> [!]: Uses parallel make %{?_smp_mflags} macro.
>
>I'm not sure why this was a failure?

Because it detects "make" without %{?_smp_mflags} (or %make_build), which it
the recommended method unless parallel make makes the build fail.

> Most of these are problems with the package itself. I'd rather fix those up later.

At least fix the man pages and bash completion file:

> kernel-tools.x86_64: W: spurious-executable-perm
> /usr/share/man/man8/turbostat.8.gz
> kernel-tools.x86_64: W: spurious-executable-perm
> /usr/share/man/man8/x86_energy_perf_policy.8.gz
> perf.x86_64: E: executable-sourced-script /etc/bash_completion.d/perf 755

Here's a simple patch to fix it:

diff -up linux-4.14/tools/perf/Makefile.perf.fix_executable_perm
linux-4.14/tools/perf/Makefile.perf
--- linux-4.14/tools/perf/Makefile.perf.fix_executable_perm    2017-11-12
19:46:13.000000000 +0100
+++ linux-4.14/tools/perf/Makefile.perf    2017-12-15 21:52:16.638189892 +0100
@@ -765,7 +765,7 @@ ifndef NO_LIBPYTHON
 endif
     $(call QUIET_INSTALL, perf_completion-script) \
         $(INSTALL) -d -m 755
'$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \
-        $(INSTALL) perf-completion.sh
'$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
+        $(INSTALL) -m 644 perf-completion.sh
'$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
     $(call QUIET_INSTALL, perf-tip) \
         $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(tip_instdir_SQ)'; \
         $(INSTALL) Documentation/tips.txt -t '$(DESTDIR_SQ)$(tip_instdir_SQ)'
diff -up linux-4.14/tools/power/x86/turbostat/Makefile.fix_executable_perm
linux-4.14/tools/power/x86/turbostat/Makefile
--- linux-4.14/tools/power/x86/turbostat/Makefile.fix_executable_perm   
2017-11-12 19:46:13.000000000 +0100
+++ linux-4.14/tools/power/x86/turbostat/Makefile    2017-12-15
20:47:32.123941300 +0100
@@ -25,4 +25,4 @@ install : turbostat
     install -d  $(DESTDIR)$(PREFIX)/bin
     install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
     install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-    install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
+    install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
diff -up
linux-4.14/tools/power/x86/x86_energy_perf_policy/Makefile.fix_executable_perm
linux-4.14/tools/power/x86/x86_energy_perf_policy/Makefile
---
linux-4.14/tools/power/x86/x86_energy_perf_policy/Makefile.fix_executable_perm 
  2017-11-12 19:46:13.000000000 +0100
+++ linux-4.14/tools/power/x86/x86_energy_perf_policy/Makefile    2017-12-15
20:48:10.671831448 +0100
@@ -24,5 +24,5 @@ install : x86_energy_perf_policy
     install -d  $(DESTDIR)$(PREFIX)/bin
     install $(BUILD_OUTPUT)/x86_energy_perf_policy
$(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
     install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-    install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
+    install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux