[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface for a portable traditional crypt function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1520569



--- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Sandro Mani from comment #4)
> Is %{_fixperms} $RPM_BUILD_ROOT/* actually required? I've never seen it used
> before.
> 
It's the default of cpanspec, didn't cause any issue with my previous perl
approved packages.

> As far as I see 
> 
> Requires:       perl(Exporter)
> Requires:       perl(XSLoader)
> 
> don't need to be explicitly specified since they are correctly picked up by
> perl-generators.
> 
> Rest looks good.

Fixed:

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/f40ee52/perl-Crypt-UnixCrypt_XS.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00688032-perl-Crypt-UnixCrypt_XS/perl-Crypt-UnixCrypt_XS-0.11-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/f40ee5284c45c5f82978238e8c5eea3b2740ba0f#diff-067baa564667abca482cba81b6e45f2b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux