https://bugzilla.redhat.com/show_bug.cgi?id=1525984 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - It would be better to use the following syntax %global with_python3 1 → %bcond_without python3 And: %if 0%{?with_python3} → %if %{with python3} - In the following comment, double the % to avoid macros replacement: #Source0: https://files.pythonhosted.org/packages/source/r/%%{pypi_name}/%%{pypi_name}-%%{version}.tar.gz - Add _example to %doc - BuildRequires: pytest → BuildRequires: python2-pytest - Run the tests provided: %check PYTHONPATH=$PYTHONPATH:%{buildroot}%{python2_sitelib} py.test-2 %if %{with python3} PYTHONPATH=$PYTHONPATH:%{buildroot}%{python3_sitelib} py.test-3 %endif - Be more specific in %files: %files -n python2-%{pname} %license LICENSE %doc README.rst %{python2_sitelib}/ruamel/ %{python2_sitelib}/ruamel.std.pathlib-%{version}-py?.?.egg-info/ %{python2_sitelib}/ruamel.std.pathlib-%{version}-py?.?-nspkg.pth %if %{with python3} %files -n python%{python3_pkgversion}-%{pname} %license LICENSE %doc README.rst %{python3_sitelib}/ruamel/ %{python3_sitelib}/ruamel.std.pathlib-%{version}-py?.?.egg-info/ %{python3_sitelib}/ruamel.std.pathlib-%{version}-py?.?-nspkg.pth %endif -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
