https://bugzilla.redhat.com/show_bug.cgi?id=1522917 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > Description > TODO: Please update the description to provide a bit more information. > E.g. to something like this: > Algorithm::Loops provides several functions (NestedLoops, MapCar*, Filter, > and NextPermute*) for doing different types of looping constructs. By > default, no functions are exported into a namespace. Ok. > BuildRequires are ok > FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to > 6.76 or higher, because NO_PACKLIST option was added in this version. Ok. > $ rpm -qp --requires perl-Algorithm-Loops-1.032-1.fc28.noarch.rpm | sort | > uniq -c > 1 perl(Carp) > 2 perl(Exporter) > 1 perl(:MODULE_COMPAT_5.26.1) > 2 perl(strict) > 2 perl(vars) > 1 perl(warnings) > 1 rpmlib(CompressedFileNames) <= 3.0.4-1 > 1 rpmlib(FileDigests) <= 4.6.0-1 > 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > 1 rpmlib(PayloadIsXz) <= 5.2-1 > Binary requires are almost Ok. > FIX: Please remove explicit run-requires of 'perl(Exporter)', > 'perl(strict)' and 'perl(vars)', because they are found by > generators. Ok. > TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in > %install. Ok. > TODO: Please add 'ex' to %doc. Not change. The package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx