[Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1268698

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch@xxxxxxxxxx



--- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Remove Coveralls dependecy
  - We don't care about code coverage, so Coveralls pulls in just more
    unnecessary dependencies. Please remove the dependency. This might be the
    medicine:

    ~~~
    # We don't care about code coverage.
    sed -i '/[cC]overalls/ s/^/#/' spec/spec_helper.rb
    ~~~

* Remove the rubygem(guard) dependnecy.
  - Is this dependency required? So far, I have not installed the package and
it
    does not look to be required.

* Make sure the test suite is working.
  - It seems that spec_helper library needs to be explicitly loaded to run the
    test suite.
  - It seems that Gemfile is missing to execute some tests. This should help:

     ~~~
     echo "source 'http://rubygems.org'" > Gemfile
     ~~~

  - the "-Ilib" is not required
  - You don't have to delete the test suite after its execution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux