https://bugzilla.redhat.com/show_bug.cgi?id=1522917 --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description TODO: Please update the description to provide a bit more information. E.g. to something like this: Algorithm::Loops provides several functions (NestedLoops, MapCar*, Filter, and NextPermute*) for doing different types of looping constructs. By default, no functions are exported into a namespace. URL and Source0 are ok All tests passed BuildRequires are ok FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to 6.76 or higher, because NO_PACKLIST option was added in this version. $ rpm -qp --requires perl-Algorithm-Loops-1.032-1.fc28.noarch.rpm | sort | uniq -c 1 perl(Carp) 2 perl(Exporter) 1 perl(:MODULE_COMPAT_5.26.1) 2 perl(strict) 2 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are almost Ok. FIX: Please remove explicit run-requires of 'perl(Exporter)', 'perl(strict)' and 'perl(vars)', because they are found by generators. $ rpm -qp --provides perl-Algorithm-Loops-1.032-1.fc28.noarch.rpm | sort | uniq -c 1 perl(Algorithm::Loops) = 1.032 1 perl-Algorithm-Loops = 1.032-1.fc28 Binary provides are Ok. $ rpmlint ./perl-Algorithm-Loops* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in %install. TODO: Please add 'ex' to %doc. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. The package is not approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
