https://bugzilla.redhat.com/show_bug.cgi?id=1516117 --- Comment #3 from Michal Ambroz <rebus@xxxxxxxxx> --- Spec URL: http://rebus.fedorapeople.org/SPECS/python-hexdump.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/python-hexdump-3.4-0.1.20160818hg66325cb5fed8.fc27.src.rpm Thank you for review. >- Your patch should link to upstream bugs/comments/lists. added >- Your snapshot must follows the Fedora versioning guidelines [1]. Changed as recommended to add also the commit date. >- Instead of use python%{python3_pkgversion}-setuptools, you can use py3_dist This is recommended way for EPEL where possibly more than one python 3 versions available simultaneously https://fedoraproject.org/wiki/PackagingDrafts:Python3EPEL >- The source version is different from the changelog header. > The Version is set to 3.4 and the changelog points to 3.3-1 Fixed - 3.4-0.1.20160818hg66325cb5fed8 it is now. >- There are rpmlint warnings on the python3 rpm package. Mine was complaining only about missing manpage, which is not part of the original package. $ rpmlint python-hexdump.spec ~/rpmbuild/RPMS/noarch/python2-hexdump-3.4-0.1.20160818hg66325cb5fed8.fc27.noarch.rpm ~/rpmbuild/RPMS/noarch/python3-hexdump-3.4-0.1.20160818hg66325cb5fed8.fc27.noarch.rpm ~/rpmbuild/SRPMS/python-hexdump-3.4-0.1.20160818hg66325cb5fed8.fc27.src.rpm python3-hexdump.noarch: W: no-manual-page-for-binary hexdumpy 3 packages and 1 specfiles checked; 0 errors, 1 warnings. I have added the man page to clean this warning. > - Your rpm packages are creating files in the wrong directory. > All files installed by the package are being created in the > /usr/lib/python3.6/site-packages directory, instead > of /usr/lib/python3.6/site-packages/hexdump/ directory. I do not like it either, but this is where the author is placing it. Same will result from for example "pip install hexdump". >- Some files have unknown license. unfortunate that the license is not referenced in each of these files, but I believe it is reasonable to believe that the package liense applies, which is public domain. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
