https://bugzilla.redhat.com/show_bug.cgi?id=1524245 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - Not useful: %if ! 0%{?with_bundled} export GOPATH=$(pwd):%{gopath} %else echo "Unable to build from bundled deps. No Godeps nor vendor directory" exit 1 %endif - Remove unused stuff: # Build with debug info rpm %global with_debug 1 # Run tests in check section %global with_check 1 - What are you trying to do here? You make a directory just to remove it on the next line: %build mkdir -p src/%{import_path} rmdir src/%{import_path} ln -s ../../../ src/%{import_path It should look like this: mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project} ln -s $(pwd) ./_build/src/%{provider_prefix} export GOPATH=$(pwd)/_build:%{gopath} %gobuild -o bin/%{executable_name} %{import_path}/cmd/%{executable_name} - Not needed even for EL6/7: # handle license on el{6,7}: global must be defined after the License field above %{!?_licensedir: %global license %doc} - Changelog info is not coherent with the header. It should just be: * Mon Dec 11 2017 Gerard Braad <me@xxxxxxxxx> 0.4-0.2 - Use a more meaningful name for your archive, with: Source0: https://%{provider_prefix}/archive/%{version}/%{name}-%{version}.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
