https://bugzilla.redhat.com/show_bug.cgi?id=1480752 --- Comment #6 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- Sorry for the unresponsiveness, it's been quite a while already and today I'm dealing with a bunch of packages I maintain at once, and this one I'm submitting. In the mean time kcov-34 was released: Spec URL: https://dridi.fedorapeople.org/review/kcov.spec SRPM URL: https://dridi.fedorapeople.org/review/kcov-34-1.fc28.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23630352 (rawhide) https://koji.fedoraproject.org/koji/taskinfo?taskID=23630994 (f27) https://koji.fedoraproject.org/koji/taskinfo?taskID=23631090 (f26) Raphael, even though you removed yourself as the reviewer, I will nevertheless answer your comments for the next reviewer. > You can directly link to pushed commits being parts of pull requests. While the commits would apply to the master branch, some wouldn't directly apply to the kcov-33 release. No longer a problem, they are part of kcov-34. > Please decide if the package is for python2 or python3, maybe both. The package can work with both, and python was only needed by the test suite that is not yet in a shape suitable for the %check step. I was discussing this upstream at the time and will hopefully find time later to revisit this. > Why not unbundle handlebars and jquery? TL;DR: They are used as static assets rather than libraries, full story in the updated spec. > What's the reason for concrete versions as noted? Required by the same guidelines you linked since I chose bundling. > Can you be more precise in %files about the file names? I'd rather lessen the packaging bureaucracy and use globs. As long as I don't own anything the package shouldn't, I believe it is allowed by the guidelines unless I missed an update at some point. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
