https://bugzilla.redhat.com/show_bug.cgi?id=1517006 --- Comment #9 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Christoph Junghans from comment #8) > Thanks @Sergey for looking for it! I had a look as well! > > > Summary: > ======= > I found (nitpicks): > - there are tests in tests/, can we run these in %check? The tests use Xvrb, and from the looks of it, it requires X running on the box? I can't manage that on the Fedora builders. > - Can you use install -p to preserve timestamps? Done. > and fedora-review found, which is ok already: > - update-desktop-database is invoked in %post and %postun if package > contains desktop file(s) with a MimeType: entry. > Note: desktop file(s) with MimeType entry in vimiv > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- > database Done. New spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/vimiv/vimiv.spec SRPM URL: https://ankursinha.fedorapeople.org/vimiv/vimiv-0.9.1-4.fc27.src.rpm * Sun Dec 10 2017 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.9.1-4 - Remove tests - Xvfb seems to require root access and X * Sun Dec 10 2017 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.9.1-3 - Add tests and other corrections based on rhbz #1517006 - update-desktop-database - preserve timestamps Cheers! Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
