https://bugzilla.redhat.com/show_bug.cgi?id=1519747 --- Comment #6 from Germano Massullo <germano.massullo@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - make %{?_smp_mflags} → %make_build > > - make install DESTDIR=%{buildroot} → %make_install > > - Not needed: > > %clean > rm -rf %{buildroot} > > - The license files should be included with the %license macro, not %doc: > > %files > %doc AUTHORS README.md CONTRIBUTING.md RELEASE-NOTES.md > %license COPYING LICENSE.LGPL > > And: > > %files devel > %doc AUTHORS README.md CONTRIBUTING.md RELEASE-NOTES.md > > %files doc > %doc AUTHORS README.md CONTRIBUTING.md RELEASE-NOTES.md doc/* > > - Remove the empty %check > > - Use pkgconfig for BR when you can: > > BuildRequires: cmake > BuildRequires: pkgconfig(openssl) > BuildRequires: xml-security-c-devel > BuildRequires: xsd > BuildRequires: pkgconfig(minizip) > # Provide xxd > BuildRequires: vim-common > > - Both Requires for the -devel -doc subpackages should include the arch > with %{?_isa}: > > Requires: %{name}%{?_isa} = %{version}-%{release} Done > - libdigidocpp.x86_64: W: file-not-utf8 /usr/share/doc/libdigidocpp/AUTHORS > > You need to convert this file to UTF-8. (See > https://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8) Is there a way to convert this with an RPM macro? I would be better than patching the file > > - libdigidocpp.x86_64: E: summary-too-long C Library offers creating, > signing and verification of digitally signed documents, according to XAdES > and XML-DSIG standards > > → The "Summary:" must not exceed 80 characters. Done https://germano.fedorapeople.org/package_reviews/libdigidocpp/libdigidocpp.spec https://germano.fedorapeople.org/package_reviews/libdigidocpp/libdigidocpp-3.13.2-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
