https://bugzilla.redhat.com/show_bug.cgi?id=1523909 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- I don't know if I am experienced enough to review this complex package, but here a few preliminary remarks: - Group: is not used anymore in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - L103: generally the BuildRoot shouldn't need to be redefined. - L117: cpuspeed is obsoleted but there is no corresponding Provides - L141: python_sitearch is already defined by default, no need to redefine it. - L187: No need for rm -rf $RPM_BUILD_ROOT - Multiple times: make %{?_smp_mflags} → %make_build - Multiple times: make DESTDIR=%{buildroot} install → %make_install - L297-303: %clean is not needed anymore. Remove it: ### ### clean ### %clean rm -rf $RPM_BUILD_ROOT - L308-312 Since /sbin/ldconfig is the only thing called in %post and %postun, use the -p syntax to avoid spawning a shell: %post -n kernel-tools-libs -p /sbin/ldconfig %postun -n kernel-tools-libs -p /sbin/ldconfig - In the %files, %defattr(-,root,root) is not needed, it is already the default. - The %changelog must contain the version and release. * Tue Nov 21 2017 Laura Abbott <labbott@xxxxxxxxxx> - VERSION-RELEASE - Add "%license COPYING" in %files for all packages combinations (I believe it's in perf, python-perf, and kernel-tools-libs) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
