https://bugzilla.redhat.com/show_bug.cgi?id=1199693 Lukas Berk <lberk@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |lberk@xxxxxxxxxx Flags| |fedora-review+ --- Comment #41 from Lukas Berk <lberk@xxxxxxxxxx> --- This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: pcp-pmda-cpp-examples : /var/lib/pcp/pmdas/pcp-pmda-cpp- examples/pmdas/simple/domain.h pcp-pmda-cpp-examples : /var/lib/pcp/pmdas /pcp-pmda-cpp-examples/pmdas/simplecpu/domain.h pcp-pmda-cpp-examples : /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/trivial/domain.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages These files are required for pmda functionality in PCP. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSL (v1.0)", "*No copyright* BSL", "Unknown or generated". 70 files have unknown license. Detailed output of licensecheck in /home/lberk/src/fedora-scm/review/pcp-pmda-cpp/licensecheck.txt The only "no copyright" file is the license itself, all other files are test files and generated. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Buildroot is not present Note: Buildroot: present but not needed Buildroot portions included for el5 era building, not applicable for modern fedora/epel [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pcp- pmda-cpp-devel , pcp-pmda-cpp-examples [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: pcp-pmda-cpp-devel-0.4.4-1.fc28.x86_64.rpm pcp-pmda-cpp-examples-0.4.4-1.fc28.x86_64.rpm pcp-pmda-cpp-0.4.4-1.fc28.src.rpm pcp-pmda-cpp-examples.x86_64: W: only-non-binary-in-usr-lib pcp-pmda-cpp-examples.x86_64: W: no-documentation pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/simple/domain.h pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/simple/simple.cpp pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/simplecpu/domain.h pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/simplecpu/simplecpu.cpp pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/trivial/domain.h pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/trivial/trivial.cpp 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: pcp-pmda-cpp-examples-debuginfo-0.4.4-1.fc28.x86_64.rpm pcp-pmda-cpp-examples-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory pcp-pmda-cpp-examples-debuginfo.x86_64: W: invalid-url URL: https://github.com/pcolby/pcp-pmda-cpp <urlopen error [Errno -2] Name or service not known> pcp-pmda-cpp-examples-debuginfo.x86_64: E: useless-provides debuginfo(build-id) pcp-pmda-cpp-devel.x86_64: W: invalid-url URL: https://github.com/pcolby/pcp-pmda-cpp <urlopen error [Errno -2] Name or service not known> pcp-pmda-cpp-examples.x86_64: W: invalid-url URL: https://github.com/pcolby/pcp-pmda-cpp <urlopen error [Errno -2] Name or service not known> pcp-pmda-cpp-examples.x86_64: W: only-non-binary-in-usr-lib pcp-pmda-cpp-examples.x86_64: W: no-documentation pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/simple/domain.h pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/simple/simple.cpp pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/simplecpu/domain.h pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/simplecpu/simplecpu.cpp pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/trivial/domain.h pcp-pmda-cpp-examples.x86_64: W: devel-file-in-non-devel-package /var/lib/pcp/pmdas/pcp-pmda-cpp-examples/pmdas/trivial/trivial.cpp 3 packages and 0 specfiles checked; 1 errors, 11 warnings. Requires -------- pcp-pmda-cpp-devel (rpmlib, GLIBC filtered): pcp-libs-devel(x86-64) pcp-pmda-cpp-examples (rpmlib, GLIBC filtered): /bin/sh libboost_program_options.so.1.64.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpcp.so.3()(64bit) libpcp.so.3(PCP_3.0)(64bit) libpcp_pmda.so.3()(64bit) libpcp_pmda.so.3(PCP_PMDA_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) pcp rtld(GNU_HASH) Provides -------- pcp-pmda-cpp-devel: pcp-pmda-cpp-devel pcp-pmda-cpp-devel(x86-64) pcp-pmda-cpp-static pcp-pmda-cpp-examples: pcp-pmda-cpp-examples pcp-pmda-cpp-examples(x86-64) Source checksums ---------------- https://github.com/pcolby/pcp-pmda-cpp/archive/v0.4.4.tar.gz#/pcp-pmda-cpp-0.4.4.tar.gz : CHECKSUM(SHA256) this package : 1141fee2eb3c7605bb6ac7ec46123203f4590bcb112b1548226e6c5253ef0481 CHECKSUM(SHA256) upstream package : 1141fee2eb3c7605bb6ac7ec46123203f4590bcb112b1548226e6c5253ef0481 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -rn ./pcp-pmda-cpp-0.4.4-1.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
