https://bugzilla.redhat.com/show_bug.cgi?id=1520585 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Jitka Plesnikova from comment #4) > > BuildRequires > > FIX: Please add missing buildrequires: > > - make - used in spec > > - perl(Carp) - lib/Test/SQL/Data.pm:16 > > - perl(File::Path) - lib/Test/SQL/Data.pm:17 > > - perl(strict) - Makefile.PL:2 > > - perl(version) - lib/Test/SQL/Data.pm:7 > > - perl(warnings) - Makefile.PL:3 > Ok. > > > $ rpm -qp --requires perl-Test-SQL-Data-0.0.6-1.fc28.noarch.rpm | sort | > > uniq -c > > 1 perl(Carp) > > 1 perl(File::Path) > > 1 perl(:MODULE_COMPAT_5.26.1) > > 1 perl(strict) > > 1 perl(Test::More) > > 1 perl(version) > > 1 perl(warnings) > > 1 perl(YAML) > > 1 rpmlib(CompressedFileNames) <= 3.0.4-1 > > 1 rpmlib(FileDigests) <= 4.6.0-1 > > 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > > 1 rpmlib(PayloadIsXz) <= 5.2-1 > > FIX: To use this module, you need to add to run-requires > > - perl(DBIx::Connector) >= 0.4.5 > > - perl(DBD::SQLite) >= 1.20 Ok. > > TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. Ok. Package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
