[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Spec file changes:

--- perl-Data-Integer.spec.old  2017-12-05 12:43:40.879000000 +0100
+++ perl-Data-Integer.spec      2017-12-06 08:44:07.666000000 +0100
@@ -6,7 +6,7 @@
 URL:            http://search.cpan.org/dist/Data-Integer/
 Source0:       
http://www.cpan.org/authors/id/Z/ZE/ZEFRAM/Data-Integer-%{version}.tar.gz
 BuildArch:      noarch
-BuildRequires:  perl >= 0:5.006
+BuildRequires:  perl >= 5.6
 BuildRequires:  perl-generators
 BuildRequires:  perl-interpreter
 BuildRequires:  perl(Carp)
@@ -18,7 +18,7 @@
 BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Pod::Coverage)
-BuildRequires:  perl(Test::Pod)
+BuildRequires:  perl(Test::Pod) >= 1.00
 BuildRequires:  perl(warnings)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

@@ -43,7 +43,7 @@
 ./Build test

 %files
-%doc Changes META.json README
+%doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*


> FIX: Write dependency on a Perl language as `perl(:VERSION) >= 5.6' instead
> as `perl >= 0:5.006'. The `perl' package uses epoch and it pulls in
> unneeded packages.

FIX: This is still not correct. The correct RPM symbol is `perl(:VERSION)', not
`perl'.

> TODO: Do not package META.json. It's not intended for end users.
Ok.

> TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.00' (t/pod_syn.t:5).
Ok.

Please fix the dependency and provide a new spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux