[Bug 1520568] Review Request: perl-Crypt-MySQL - Emulate MySQL PASSWORD() function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1520568



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add following buildrequires:
 - perl(DBI) - t/03_dbi.t:6
 - perl(Exporter) - lib/Crypt/MySQL.pm:17
 - perl(strict) - Build.PL:1
 - perl(vars) - lib/Crypt/MySQL.pm:4
 - perl(warnings) - Build.PL:2
 - perl(XSLoader) - lib/Crypt/MySQL.pm:10
FIX: Please add perl-devel and gcc, because it is XS package

$ rpm -qp --requires perl-Crypt-MySQL-0.04-1.fc28.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.26()(64bit)
      1 perl(Digest::SHA1)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
FIX: Please add run-requires
 - perl(Exporter)
 - perl(XSLoader)

$ rpm -qp --provides perl-Crypt-MySQL-0.04-1.fc28.x86_64.rpm | sort | uniq -c
      1 perl(Crypt::MySQL) = 0.04
      1 perl-Crypt-MySQL = 0.04-1.fc28
      1 perl-Crypt-MySQL(x86-64) = 0.04-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Crypt-MySQL*
perl-Crypt-MySQL.src: W: spelling-error %description -l en_US libmysqlclient ->
clientele
perl-Crypt-MySQL.x86_64: W: spelling-error %description -l en_US libmysqlclient
-> clientele
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct all 'FIX' issues and provide new spec file.

Package is not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux