https://bugzilla.redhat.com/show_bug.cgi?id=1520571 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- I believe the correct SRPM URL is <https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00683997-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.src.rpm>. I will use that for this review. URL and Source addresses are Ok. Source archive (SHA-256: 63b77ede3b639ce351525034863629af989abcbff4ab03b14fc4ead461ffa354) is original. Ok. Summary verified from lib/Data/Integer.pm. Ok. Description verified from lib/Data/Integer.pm. Ok. License verified from lib/Data/Integer.pm and README. Ok. No XS code, noarch BuildArch is Ok. FIX: Write dependency on a Perl language as `perl(:VERSION) >= 5.6' instead as `perl >= 0:5.006'. The `perl' package uses epoch and it pulls in unneeded packages. TODO: Do not package META.json. It's not intended for end users. TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.00' (t/pod_syn.t:5). All tests pass. Ok. $ rpmlint perl-Data-Integer.spec ../SRPMS/perl-Data-Integer-0.006-1.fc28.src.rpm ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm drwxr-xr-x 2 root root 0 Dec 5 14:09 /usr/share/doc/perl-Data-Integer -rw-r--r-- 1 root root 3442 Aug 7 23:08 /usr/share/doc/perl-Data-Integer/Changes -rw-r--r-- 1 root root 1633 Aug 7 23:08 /usr/share/doc/perl-Data-Integer/META.json -rw-r--r-- 1 root root 741 Aug 7 23:08 /usr/share/doc/perl-Data-Integer/README -rw-r--r-- 1 root root 8177 Dec 5 14:09 /usr/share/man/man3/Data::Integer.3pm.gz drwxr-xr-x 2 root root 0 Dec 5 14:09 /usr/share/perl5/vendor_perl/Data -rw-r--r-- 1 root root 34570 Dec 5 14:09 /usr/share/perl5/vendor_perl/Data/Integer.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(Carp) 1 perl(Exporter) 1 perl(integer) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(Data::Integer) = 0.006 1 perl-Data-Integer = 0.006-1.fc28 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm Binary dependencies resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item, consider fixing the `TODO' items and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
