https://bugzilla.redhat.com/show_bug.cgi?id=1504825 --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- As David said: - Use an apropriate license: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing , I guess ASL 2.0 - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text → You installed the COPYING file with the %doc macro but it should be with %license instead: %license %{rlibdir}/RColorBrewer/COPYING - [?]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed → You should remove: %defattr(-, root, root, -) - Also not needed: #Group: Applications/Engineering #rm -rf %{buildroot} - [!]: Buildroot is not present Note: Buildroot: present but not needed → Remove: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) → Remove: %clean rm -rf %{buildroot} - For R package you should at the very least have a %check like this: %check %{_bindir}/R CMD check %{packname} Also you'll need a sponsor, I'm not able to sponsor but I suggest introducing yourself on the fedora-devel mailing lists and do a few informal review like David did for you to show you understand the Fedora Packaging Guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
