https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@xxxxxxxx | |m) | --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- ># packaging from npm is far more easier than packaging from GH > Source0: https://registry.npmjs.org/%{npm_name}/-/%{npm_name}-%{version}.tgz Upstream does not advise that yarn sources are retrieved from npm and suggest it should be packaged from the pristine sources uploaded to GitHub. Have you verified that the sources are the same and that it is functional? >License: BSD-2-Clause We do not use SPDX identifiers in Fedora. This should be "BSD". > %files > ... > %{_bindir}/nodejs-yarn > %{_bindir}/nodejs-yarnpkg No one is going to be able to find either of these. Also, I don't know of any conflicts that exist for "%{_bindir}/yarnpkg". As for "%{_bindir}/nodejs-yarn", how are you going to make this discoverable? If you're renaming files, you also need to provide a README.Fedora that is installed into the yarn doc dir that describes our changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
