Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: java-1.7.0-icedtea - IcedTea runtime and development environments https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253691 ------- Additional Comments From fitzsim@xxxxxxxxxx 2007-08-23 12:09 EST ------- (In reply to comment #11) > A few initial questions: > > - why the need for "snapshot" in the release? The release string format is: significant_digits.OpenJDK_build.IcedTea_version IcedTea_version = snapshot means that the IcedTea tarball is a snapshot rather than an IcedTea release. I will include IcedTea 1.3 when it is released. > - is the license tag okay as it's stated? Yes, that's the new rpmlint-suggested License tag format. > - where does the access bridge source come from? http://ftp.gnome.org/pub/GNOME/sources/java-access-bridge/ I'll add a comment in the spec file. > - is generate-cacerts.pl in version control somewhere? Yes: http://icedtea.classpath.org/hg/fedora/raw-file/f38a4e9e2134/generate-cacerts.pl > - do we really need the registered trademark notice in %description? No, I suppose not. > - why doesn't the CGI script work on x86_64? can we have a note about it in the > spec? No good reason I can see. We plan to enable it before Fedora 8. I can add a comment in the meantime. > - rather than "IcedTea Plugin" can we have something more descriptive? "Browser > plugin" or "Mozilla plugin" or something? Sure. > - why the two stages of symlinking around line 313? So that you can specify e.g., "a sasl jar", "a sasl 1.7.0 jar" or "the sasl 1.7.0.0 jar". $ ls -l /usr/lib/jvm-exports/jre-1.7.0-icedtea/sasl* lrwxrwxrwx 1 root root 51 2007-07-14 21:51 /usr/lib/jvm-exports/jre-1.7.0-icedtea/sasl-1.7.0.0.jar -> ../../jvm/java-1.7.0-icedtea-1.7.0.0/jre/lib/rt.jar lrwxrwxrwx 1 root root 16 2007-07-14 21:51 /usr/lib/jvm-exports/jre-1.7.0-icedtea/sasl-1.7.0.jar -> sasl-1.7.0.0.jar lrwxrwxrwx 1 root root 16 2007-07-14 21:51 /usr/lib/jvm-exports/jre-1.7.0-icedtea/sasl.jar -> sasl-1.7.0.0.jar > - why the ghost touching? ISTR this addressing some RPM warning. I'll experiment with it for the next package build. > - should the man pages work with alternatives? or do I always have to use 'man > java-java-1.7.0-icedtea? looking at the stuff in %post, it appears it should work. They should work, e.g. "man java" should bring up java-java-1.7.0-icedtea when IcedTea's java alternative is selected. > - do some of the single quotes around line 384 need escaping? No, the three strings are concatenated in shell, e.g.: $ echo 'a'b'c' abc > - you had mentioned issues with binfmt_misc at one point to me - is that sorted out? I'm not sure what issues I mentioned. I enabled binfmt_misc as an experiment so that people could try it. I'm not sure if it's useful or not. It only helps on the command-line, since GNOME uses a different mechanism for executing files. > - wow, the number of alternatives is crazy! Yes, but all (except maybe the jce policy one) are necessary. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review