https://bugzilla.redhat.com/show_bug.cgi?id=1519749 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - make %{?_smp_mflags} → %make_build - make install DESTDIR=%{buildroot} → %make_install - The policies regarding scriplets have changed since Fedora > 24, thus update-desktop-database and update-mime-database are not needed anymore. Only remains gtk-update-icon-cache: %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : - The license files should be included with the %license macro, not %doc: %files %doc AUTHORS README.md CONTRIBUTING.md RELEASE-NOTES.md %license COPING LICENSE.LGPL LICENSE.LGPL - Use pkgconfig for BR when you can: BuildRequires: cmake BuildRequires: desktop-file-utils BuildRequires: gettext BuildRequires: pkgconfig(libdigidocpp) BuildRequires: openldap-devel BuildRequires: pkgconfig(openssl) BuildRequires: pkgconfig(Qt5Designer) BuildRequires: pkgconfig(libpcsclite) >= 1.7 BuildRequires: libappstream-glib BuildRequires: qtsingleapplication-qt5-devel Requires: hicolor-icon-theme # Dynamically loaded library Requires: opensc%{?_isa} Requires: pcsc-lite-ccid%{?_isa} Requires: liberation-fonts - For the nautilus subpackage, add %{?_isa}: Requires: %{name}%{?_isa} = %{version}-%{release} - qdigidoc.x86_64: W: file-not-utf8 /usr/share/doc/qdigidoc/AUTHORS Convert AUTHORS to UTF-8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
