[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Jaroslav Prokop <jar.prokop@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jar.prokop@xxxxxxxx



--- Comment #1 from Jaroslav Prokop <jar.prokop@xxxxxxxx> ---
Hi Ilya, I did an informal review on this package.

* Outdated version
  - You should make it up to date with upstream release and also update it to   
    more current fedora releases

* Group is not needed
  - Group tags are not needed currently, so you should delete lines:
~~~
Group: Development/Languages
~~~

~~~
Group: Documentation
~~~

In my opinion you could run the tests without -Ilib option.

Otherwise the package looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux