[Bug 1519324] Review Request: onedrive - OneDrive Free Client written in D

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1519324

Iwicki Artur <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #1 from Iwicki Artur <fedora@xxxxxxxxxx> ---
>Group: Applications/Internet
The "Group:" tag should not be used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>URL: https://github.com/skilion/onedrive
I think this should use the %{repo} macro declared at the start of the spec.

>This do not support OneDrive for business
Broken grammar. "This does not support OneDrive For Business", or maybe
"OneDrive For Business is not supported".

>sed -i 's/\/usr\/local/\/usr/' Makefile
Sed allows to use any character as the regex delimiter; if you use something
else than the slash (e.g. a pipe "|"), you won't have to escape every slash.

Also, you either forgot to roll the "Release:" tag back to 1, or there's a
missing changelog entry for 1.0.1-2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux